Taking a raw ref of a deref is always safe #18711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 27, 2024
…, r=Mark-Simulacrum [beta] Backport rust-lang/rust-analyzer#18711 rust-lang/rust-analyzer#18711
bors-ferrocene bot
added a commit
to ferrocene/ferrocene
that referenced
this pull request
Jan 2, 2025
1177: Automated pull from upstream `beta` r=tshepang a=ferrocene-automations[bot] This PR pulls the following changes from the upstream repository: * `134464`: [[beta] Backport rust-lang/rust-analyzer#18711](https://www.github.com/rust-lang/rust/issues/134464) Co-authored-by: Lukas Wirth <lukastw97@gmail.com> Co-authored-by: bors <bors@rust-lang.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bors-ferrocene bot
added a commit
to ferrocene/ferrocene
that referenced
this pull request
Jan 3, 2025
1181: Automated pull from upstream `beta` r=pvdrz a=ferrocene-automations[bot] This PR pulls the following changes from the upstream repository: * `135048`: [[beta] backports](https://www.github.com/rust-lang/rust/issues/135048) * `134464`: [[beta] Backport rust-lang/rust-analyzer#18711](https://www.github.com/rust-lang/rust/issues/134464) Co-authored-by: Lukas Wirth <lukastw97@gmail.com> Co-authored-by: bors <bors@rust-lang.org> Co-authored-by: Esteban Küber <esteban@kuber.com.ar> Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com> Co-authored-by: Tim (Theemathas) Chirananthavat <theemathas@gmail.com> Co-authored-by: Michael Goulet <michael@errs.io> Co-authored-by: Niko Matsakis <nikomat@amazon.com> Co-authored-by: 许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com> Co-authored-by: Michael Howell <michael@notriddle.com> Co-authored-by: Lukas Markeffsky <@> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bors-ferrocene bot
added a commit
to ferrocene/ferrocene
that referenced
this pull request
Jan 5, 2025
1186: Automated pull from upstream `beta` r=pvdrz a=ferrocene-automations[bot] This PR pulls the following changes from the upstream repository: * `135048`: [[beta] backports](https://www.github.com/rust-lang/rust/issues/135048) * `134464`: [[beta] Backport rust-lang/rust-analyzer#18711](https://www.github.com/rust-lang/rust/issues/134464) Co-authored-by: Lukas Wirth <lukastw97@gmail.com> Co-authored-by: bors <bors@rust-lang.org> Co-authored-by: Esteban Küber <esteban@kuber.com.ar> Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com> Co-authored-by: Tim (Theemathas) Chirananthavat <theemathas@gmail.com> Co-authored-by: Michael Goulet <michael@errs.io> Co-authored-by: Niko Matsakis <nikomat@amazon.com> Co-authored-by: 许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com> Co-authored-by: Michael Howell <michael@notriddle.com> Co-authored-by: Lukas Markeffsky <@> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bors-ferrocene bot
added a commit
to ferrocene/ferrocene
that referenced
this pull request
Jan 7, 2025
1190: Automated pull from upstream `stable` r=tshepang a=ferrocene-automations[bot] This PR pulls the following changes from the upstream repository: * `135162`: [Prepare Rust 1.84.0 stable release](https://www.github.com/rust-lang/rust/issues/135162) * `135048`: [[beta] backports](https://www.github.com/rust-lang/rust/issues/135048) * `134464`: [[beta] Backport rust-lang/rust-analyzer#18711](https://www.github.com/rust-lang/rust/issues/134464) Co-authored-by: Lukas Wirth <lukastw97@gmail.com> Co-authored-by: bors <bors@rust-lang.org> Co-authored-by: Esteban Küber <esteban@kuber.com.ar> Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com> Co-authored-by: Tim (Theemathas) Chirananthavat <theemathas@gmail.com> Co-authored-by: Michael Goulet <michael@errs.io> Co-authored-by: Niko Matsakis <nikomat@amazon.com> Co-authored-by: 许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com> Co-authored-by: Michael Howell <michael@notriddle.com> Co-authored-by: Lukas Markeffsky <@> Co-authored-by: Noratrieb <48135649+Noratrieb@users.noreply.github.com> Co-authored-by: Pietro Albini <pietro.albini@ferrous-systems.com> Co-authored-by: Pietro Albini <pietro@pietroalbini.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bors-ferrocene bot
added a commit
to ferrocene/ferrocene
that referenced
this pull request
Jan 7, 2025
1186: Automated pull from upstream `beta` r=pvdrz a=ferrocene-automations[bot] This PR pulls the following changes from the upstream repository: * `135048`: [[beta] backports](https://www.github.com/rust-lang/rust/issues/135048) * `134464`: [[beta] Backport rust-lang/rust-analyzer#18711](https://www.github.com/rust-lang/rust/issues/134464) 1190: Automated pull from upstream `stable` r=tshepang a=ferrocene-automations[bot] This PR pulls the following changes from the upstream repository: * `135162`: [Prepare Rust 1.84.0 stable release](https://www.github.com/rust-lang/rust/issues/135162) * `135048`: [[beta] backports](https://www.github.com/rust-lang/rust/issues/135048) * `134464`: [[beta] Backport rust-lang/rust-analyzer#18711](https://www.github.com/rust-lang/rust/issues/134464) Co-authored-by: Lukas Wirth <lukastw97@gmail.com> Co-authored-by: bors <bors@rust-lang.org> Co-authored-by: Esteban Küber <esteban@kuber.com.ar> Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com> Co-authored-by: Tim (Theemathas) Chirananthavat <theemathas@gmail.com> Co-authored-by: Michael Goulet <michael@errs.io> Co-authored-by: Niko Matsakis <nikomat@amazon.com> Co-authored-by: 许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com> Co-authored-by: Michael Howell <michael@notriddle.com> Co-authored-by: Lukas Markeffsky <@> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Noratrieb <48135649+Noratrieb@users.noreply.github.com> Co-authored-by: Pietro Albini <pietro.albini@ferrous-systems.com> Co-authored-by: Pietro Albini <pietro@pietroalbini.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#129248
This needs backporting to 1.84.0 beta